Add slack bot integration #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Apr 21, 2018
app/dashboard/notifications.py
Outdated
| return False | ||
| return True | ||
|
|
||
| def build_message_for_slack(bounty, event_name): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
app/dashboard/notifications.py
Outdated
| title = bounty.title if bounty.title else bounty.github_url | ||
| msg = f"{event_name.replace('bounty', 'funded_issue')} worth {round(bounty.get_natural_value(), 4)} {bounty.token_name} " \ | ||
| f"{usdt_details}" \ | ||
| f"{bounty.token_name}: {title} \n\n{bounty.get_absolute_url()}" | ||
| return msg | ||
|
|
||
| def maybe_market_to_user_slack(bounty, event_name): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
app/dashboard/notifications.py
Outdated
| sc.api_call("chat.postMessage", channel=channel, text=msg) | ||
| username = uri_array[1] | ||
| repo = uri_array[2] | ||
| subscribers = EmailSubscriber.objects.filter(profile__handle=username, repos__contains=[repo]).exclude(slack_token='', slack_channel='') |
There was a problem hiding this comment.
E501 line too long (144 > 120 characters)
| migrations.AddField( | ||
| model_name='emailsubscriber', | ||
| name='repos', | ||
| field=django.contrib.postgres.fields.ArrayField(base_field=models.CharField(max_length=200), blank=True, default=[], size=None), |
There was a problem hiding this comment.
E501 line too long (140 > 120 characters)
app/marketing/views.py
Outdated
| @@ -614,6 +618,43 @@ def email_settings(request, key): | |||
| } | |||
| return TemplateResponse(request, 'settings/email.html', context) | |||
|
|
|||
| def slack_settings(request): | |||
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
==========================================
- Coverage 33.45% 33.14% -0.31%
==========================================
Files 100 100
Lines 6238 6305 +67
Branches 755 765 +10
==========================================
+ Hits 2087 2090 +3
- Misses 4045 4109 +64
Partials 106 106
Continue to review full report at Codecov.
|
stickler-ci
reviewed
Apr 21, 2018
| model_name='emailsubscriber', | ||
| name='repos', | ||
| field=django.contrib.postgres.fields.ArrayField(base_field=models.CharField(max_length=200), blank=True, | ||
| default=[], size=None), |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
- send same messages to user's slack as to gitcoin's slack Fixes: gitcoinco#259
darkdarkdragon
force-pushed
the
slacknotify
branch
from
fbbe8cc to
aae7d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Testing
Tested manually
Refers/Fixes
Fixes: #259